Skip to content

Conversation

aatreyee257
Copy link

@aatreyee257 aatreyee257 commented Aug 4, 2025

Description

Improving DA user experience.
Git issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257 aatreyee257 marked this pull request as ready for review August 6, 2025 08:24
@aatreyee257
Copy link
Author

image

@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257 aatreyee257 self-assigned this Aug 17, 2025
@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257
Copy link
Author

/run pipeline

@aatreyee257
Copy link
Author

/run pipeline

@imprateeksh
Copy link
Member

Small typo error -
image

Copy link
Member

@imprateeksh imprateeksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take reference from similar PRs and address the points. Some points are highlighted here as well. Please make changes according to the module you are working on.

PRs for reference:
terraform-ibm-modules/terraform-ibm-watsonx-ai#148
terraform-ibm-modules/terraform-ibm-mq-cloud#148
terraform-ibm-modules/terraform-ibm-kms-all-inclusive#726
terraform-ibm-modules/terraform-ibm-secrets-manager-public-cert-engine#246

@aatreyee257
Copy link
Author

Project Screenshot:
image

Copy link

@Vipin654 Vipin654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just 2 minor comments

  • point 4 of epic issue is not taken care
  • addon mapping should not be done for provider_visibility

@aatreyee257
Copy link
Author

/run pipeline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants